-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properly deprecate the current behavior of the default_format
option
#1419
Conversation
i.e. match `cfunits` before `cf`. There might be a better way to do this, though.
which allows emitting a DeprecationWarning
apparently, there's a issue with installing Also, I just noticed that |
Yes I will make PR to resolve the error for uncertainties |
Should be okay if you rebase @keewis |
Gonna look into this. but looks good so far ! |
@keewis can u rebase to fix conflicts |
@keewis can you just change the condition that is duplicated to use |
sure
I didn't (and I also can't see them anywhere), which is why I was confused when you posted #1450 (comment). Can you check if those comments are still pending and submit if so? |
if it says "pending" you have to submit the review |
Oh I see, I thought those kind of review comments were automatically sent. My bad then. |
Co-authored-by: Jules Chéron <43635101+jules-ch@users.noreply.github.com>
I like this PR and it is a great idea to split uspec and mspec early on |
As discussed in #1407, this rolls back the change in behavior of
default_format
(split the spec inmspec
anduspec
and decide for each part individually if the default should be used).I also decided that this would be a good opportunity to rewrite the code such that
mspec
anduspec
are separated as early as possible, such that fixing #1413 becomes a really small change.pre-commit run --all-files
with no errors